Add MariaDB Support #260
Open
Add MariaDB Support #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR - looks like you just need to run isort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :D
I needed MariaDB Support and since MySQL is available, I took the existing files and basically did a copy paste addition with a few changes to use the new adapter. I hope the test stuff works (we will see in this PR, I guess) and the connector just works. I just added the support. I can report that using a connection works. I will now get to integrate pydapper more into our project :D
Thanks for your work and I hope here's some useful stuff, too.
Oh and btw. I am hopping around languages and Python isn't exactly the language I am normally using. So please have an eagle eye when reviewing :)
EDIT: Well sometimes you do stupid stuff. In this instance we're working with async webserver and I didn't notice the mariadb was fully synchronous. I am switching to aiomysql now and will report back how it works. This branch is now a bit of a mess for the time being. So maybe if you choose to merge support for one or the other driver, we can clean this up. I hope to use aiomysql now in production.