MAKE_FUNCTION & SET_FUNCTION_ATTRIBUTE_A for 3.13 #579
Draft
CarrBen wants to merge 18 commits intozrax:masterfrom
Draft
MAKE_FUNCTION & SET_FUNCTION_ATTRIBUTE_A for 3.13 #579CarrBen wants to merge 18 commits intozrax:masterfrom
CarrBen wants to merge 18 commits intozrax:masterfrom
Conversation
Compiled with the 3.4.10-alpine container
Compiled with 3.0.1 locally built container
…a more appropriate area of ASTree
Author
|
I started looking at CALL_KW and found a bug in my LOAD_ATTR implementation, I put too much inside the if(operand). |
Contributor
|
Thanks a lot for your contribution @CarrBen . Unfortunately there seems to be a bug with |
…. Apply 3.13 NULL ordering change to LOAD_GLOBAL
Author
|
Thanks for taking a look @whoami730, I had spotted an issue with LOAD_ATTR last night, and I'd completely missed updating LOAD_GLOBAL to work with 3.13. I've pushed a further commit with updates for both Opcodes and it passes your test case on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT again...
I'm setting this one up as another Draft, as this builds upon the changes in #539 & #538
I've mainly done this because these things naturally build on top of each other as the Opcode evolve when moving forward through the Python versions. For example, the handling of Function arguments within SET_FUNCTION_ATTRIBUTE_A is the same as MAKE_FUNCTION in Python 3.6-3.12.
Summary
Tests
Related Issues
#573
#569
#568
#542
#498