Skip to content

Refactoring DoReplace #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactoring DoReplace #32

wants to merge 2 commits into from

Conversation

VladimirTakeda
Copy link
Collaborator

@VladimirTakeda VladimirTakeda commented Aug 30, 2024 •
edited
Loading

This pull request prepares for the Statistic Collection issue mentioned in #29.

Key changes include:

  • Simplified all the DoReplace methods.
  • Created a base class, BaseReplacer, with a SendFurther method to track all replacements.

@VladimirTakeda VladimirTakeda self-assigned this Aug 31, 2024
@zproksi zproksi self-requested a review September 1, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zproksi zproksi Awaiting requested review from zproksi

Assignees

@VladimirTakeda VladimirTakeda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VladimirTakeda