Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load each components' default YAML files #3449

Draft
wants to merge 2 commits into
base: v2.x/staging
Choose a base branch
from

Conversation

1000TurquoisePogs
Copy link
Member

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • Feature

Relevant issues

Assists with zowe/community#1857

Changes proposed in this PR

This PR allows for components to ship default YAML files which zwe will incorporate into the overall yaml config for when that particular component loads. Components need no code changes to take advantage of this. They will still receive env vars to use. However, they will now have env vars that consider values from their own defaults.yaml file, and will also have a merged yaml file available to them in workspace/.env/componentname

The purpose of this is to:

  • reduce configuration values the user needs to see by default
  • Allow servers to take configuration out of code and put it into yaml templates
  • Allow users to see those defaults from those yamls, and then be better equipped to build their own yaml customizations.

Does this PR introduce a breaking change?

  • No

…the server will use when loading env vars

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

PAX build 3242 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5247613797

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Test workflow 2771 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.9.0-PR-3449/zowe-2.9.0-pr-3449-3242-20230612192145.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5247674281

…olders due to older hardcoding

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

PAX build 3249 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5259617719

@1000TurquoisePogs 1000TurquoisePogs marked this pull request as ready for review June 13, 2023 19:29
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Test workflow 2777 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.9.0-PR-3449/zowe-2.9.0-pr-3449-3249-20230613193503.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5259678928

@1000TurquoisePogs 1000TurquoisePogs marked this pull request as draft August 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants