Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate rename to PDS members #3315

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix: Propagate rename to PDS members #3315

merged 5 commits into from
Nov 14, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 13, 2024

Proposed changes

Fixes #3314

Release Notes

Milestone: 3.0.3

Changelog:

  • Fixed an issue where opening a PDS member after renaming an expanded PDS resulted in an error. #3314

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (16963db) to head (16155b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3315    +/-   ##
========================================
  Coverage   92.98%   92.99%            
========================================
  Files         116      116            
  Lines       12051    12058     +7     
  Branches     2768     2653   -115     
========================================
+ Hits        11206    11213     +7     
  Misses        843      843            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 13, 2024
Copy link

📅 Suggested merge-by date: 11/27/2024

zFernand0
zFernand0 previously approved these changes Nov 14, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that even though we are looping through the opened members, the text editor doesn't switch focus to each one of them (like it used to happen back in like v1.10.0 or something 😋

TL;DR: LGTM! 😋

JillieBeanSim
JillieBeanSim previously approved these changes Nov 14, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix @traeok

@JillieBeanSim JillieBeanSim dismissed stale reviews from zFernand0 and themself via 16155b0 November 14, 2024 14:32
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit b3d654c into main Nov 14, 2024
33 checks passed
@zFernand0 zFernand0 deleted the fix/rename-pds branch November 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Renaming a PDS does not update member nodes
3 participants