Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system tests for mac #2339

Merged
merged 25 commits into from
Nov 1, 2024
Merged

Fix system tests for mac #2339

merged 25 commits into from
Nov 1, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 31, 2024 •
edited
Loading

What It Does

Fixes various system test issues to allow the tests to run better on high performance Mac computers and alternate systems.
This includes:

  • Skipping tests that rely on CIM for job cancellation
  • Appending missing shebang lines
  • Making shell scripts user executable
  • Fixing DSN name too long errors
  • Adding sleeps to scripts that require more time to pass between commands
  • Fixing incorrect logic in shell scripts that used until
  • Using commands that are intercompatible with MacOS (due to grep -P not existing on Mac)
  • Fixing Logs handler incorrectly using client time when no time is specified
  • Fixing an HTTP 1.1 socket reuse error with Node 20 and above
  • Fixing the wrong port tests to also handle an ETIMEDOUT error due to firewalls dropping traffic instead of refusing it.

How to Test

Review Checklist
I certify that I have:

Additional Comments

@awharn
Add missing shebang lines
4f2d799 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Add checks that required CLI scripts ran correctly.
2f8655d 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Use local IP address due to AggregateError
0da0ad0 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Use cross platform supported tools in Bash scripts
9777060 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix DS name too long issues
f7a61a6 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Handle ECONNRESET error when reusing sockets in AbstractRestClient
724cb45 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Add CIM flag to skip CIM 1.0 tests on systems that do not support it
cd63e8f 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix system tests where firewall can return a timeout instead
ff32587 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix another DSN name too long error
0b06d95 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Add missing CIM related tests
eec3141 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Add timeout tests
5f8c518 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix lint error
dd99b92 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix Logs error (#2336)
e56c962 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Add a sleep for fast running systems
0326f8b 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix Issue Tso issue
bd2ccd4 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Replace mMessage with message
5068ade 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix small timing issues
06b6509 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix more timing issues & logic errors
45e1e65 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn self-assigned this Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.12%. Comparing base (715242f) to head (dbe3e4a).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...perative/src/rest/src/client/AbstractRestClient.ts 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   91.12%   91.12%   -0.01%     
==========================================
  Files         636      636              
  Lines       18000    18007       +7     
  Branches     3862     3865       +3     
==========================================
+ Hits        16403    16408       +5     
- Misses       1596     1598       +2     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awharn
Fix errors that surfaced on Jenkins
62a48b1 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Update defaults to prevent breakage
356d277 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Resolve some TSO system test timing issues
b3dda51 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix test
d37d431 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix system test snapshot
dbe3e4a 
Signed-off-by: Andrew W. Harn <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

t1m0thyj
t1m0thyj approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn for testing the CLI on more environments and finding and fixing a few bugs along the way! 😋

@awharn awharn merged commit 952c1ac into master Nov 1, 2024
17 of 19 checks passed
@awharn awharn deleted the fix-system-tests-for-mac branch November 1, 2024 16:51
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

@t1m0thyj t1m0thyj linked an issue Nov 4, 2024 that may be closed by this pull request
zowe zos-logs list logs command assumes time is now from Client #2336
Open
@awharn awharn mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaxceron anaxceron anaxceron approved these changes

@gejohnston gejohnston gejohnston approved these changes

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@zFernand0 zFernand0 Awaiting requested review from zFernand0

@traeok traeok Awaiting requested review from traeok

@jace-roell jace-roell Awaiting requested review from jace-roell

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees

@awharn awharn

Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Zowe CLI Squad
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zowe zos-logs list logs command assumes time is now from Client
4 participants
@awharn @t1m0thyj @gejohnston @anaxceron