Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zowe zos-logs list logs command assumes time is now from Client #2336

Open
awharn opened this issue Oct 30, 2024 · 2 comments · Fixed by #2339
Open

zowe zos-logs list logs command assumes time is now from Client #2336

awharn opened this issue Oct 30, 2024 · 2 comments · Fixed by #2339
Labels
bug Something isn't working needs-ported Indicates that a PR needs to be ported (master - lts-incremental) priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@awharn
Copy link
Member

awharn commented Oct 30, 2024

Describe the bug

The command assumes the date and time from the client perspective. This can cause logs to be omitted, or the command to fail, if the server time differs from the client time (usually off by a few seconds to a minute). The API uses the server time for now if no time is passed. By default, we should not be passing the client time to the server, but let the server use its current time to get the most up to date logs (and prevent errors).

Expected and actual results

Describe your environment

Additional context
@awharn awharn added bug Something isn't working new The issue wasn't triaged yet labels Oct 30, 2024
@github-actions GitHub Actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

awharn added a commit that referenced this issue Oct 30, 2024
@awharn
Fix Logs error (#2336)
e56c962 
Signed-off-by: Andrew W. Harn <[email protected]>
@t1m0thyj t1m0thyj linked a pull request Nov 4, 2024 that will close this issue
Fix system tests for mac #2339
Merged
4 tasks
@t1m0thyj t1m0thyj closed this as completed Nov 4, 2024
@t1m0thyj
Copy link
Member

t1m0thyj commented Nov 4, 2024

Reopening until the fix is backported to V2

@t1m0thyj t1m0thyj reopened this Nov 4, 2024
@JTonda JTonda added needs-ported Indicates that a PR needs to be ported (master - lts-incremental) priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. and removed new The issue wasn't triaged yet labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-ported Indicates that a PR needs to be ported (master - lts-incremental) priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Zowe CLI Squad
Status: Medium Priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix system tests for mac zowe/zowe-cli
3 participants
@t1m0thyj @JTonda @awharn