Add cache versioning for Read Aloud audio#219
Merged
Conversation
Propagate the server's per-provider-group cacheVersion into each voice config so the host can version cache keys, and honor Cache-Control: no-store by skipping storage.
API is already returning them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates the server's per-provider-group
cacheVersion(from/tts/voices) into each flattened voice config so the client can version its local audio cache keys, and surfacesCache-Control: no-storeso the client can skip caching those responses.RemoteVoiceConfig/VoicesResponseTier: addcacheVersion;getAudioreturn addsnoStoreparseVoicesResponse(): copy each tier config'scacheVersiononto every voiceno-store, prune stale entries once per sessionThe actual cache-key/pruning/no-store enforcement lives client-side.
Needed by: zotero/zotero#5967