onInitialized is now being sent to Android side after the WebView port was set#217
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From now the flow on Android works like this:
When reader is being loaded in the Webview, Android side waits for a WebView to fire it's callback -
onWebViewLoadPage, which signals that reader code was loaded.Then I execute some JS code to pass WebView Port to JS side
I wait for
onInitializedto be returned from the JS sideOnly then I execute createView against the reader.
This flow should hopefully ensure that the Reader is fully loaded and Port was set before any of the requests are executed against reader or before reader itself wants to send some messages to Android side.