Skip to content

Commit

Permalink
Dockerfile cleanup (#4)
Browse files Browse the repository at this point in the history
* Dockerfile cleanup

* add comment in workflow
  • Loading branch information
zostaw committed Dec 2, 2023
1 parent f2f0632 commit 9741c3a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/push_dockerhub.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Dockerhub Release

# Executed on direct push, or after Pull Request was completed.
# It will push the image to Dockerhub.

on:
push:
branches:
Expand Down
16 changes: 0 additions & 16 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ COPY requirements.txt /tmp/requirements.txt
RUN pip install --upgrade pip
RUN pip install --no-cache-dir -r /tmp/requirements.txt

RUN mkdir ~/.ssh
RUN echo "Host *" >> ~/.ssh/config
RUN echo "StrictHostKeyChecking no" >> ~/.ssh/config

# URL under which static (not modified by Python) files will be requested
# They will be served by Nginx directly, without being handled by uWSGI
ENV STATIC_URL /static
Expand All @@ -33,16 +29,4 @@ WORKDIR /app
# Make /app/* available to be imported by Python globally to better support several use cases like Alembic migrations.
ENV PYTHONPATH=/app

# Move the base entrypoint to reuse it
#RUN mv /entrypoint.sh /uwsgi-nginx-entrypoint.sh
# Copy the entrypoint that will generate Nginx additional configs
#COPY entrypoint.sh /entrypoint.sh
#RUN chmod +x /entrypoint.sh

#ENTRYPOINT ["/entrypoint.sh"]

# Run the start script provided by the parent image tiangolo/uwsgi-nginx.
# It will check for an /app/prestart.sh script (e.g. for migrations)
# And then will start Supervisor, which in turn will start Nginx and uWSGI

CMD ["flask", "run", "--host", "0.0.0.0", "--port", "8080", "--cert", "cert.pem", "--key", "key.pem"]

0 comments on commit 9741c3a

Please sign in to comment.