Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user group serializer send out stats visibility #4236

Merged

Conversation

yuenmichelle1
Copy link
Collaborator

User Group Serializer to send stats_visibility

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review August 22, 2023 18:12
@yuenmichelle1
Copy link
Collaborator Author

@zwolf tagged you as reviewer to give you a heads up of the change...but the change is simple enough, i'mma go ahead and merge.

@yuenmichelle1 yuenmichelle1 merged commit cfc8279 into master Aug 22, 2023
7 checks passed
@yuenmichelle1 yuenmichelle1 deleted the user_groups_serializer-display-stats_visibility branch August 22, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant