Project Builder: update thumbnails options for Survey Task

[shaunanoordin]

PR Overview

Fixes #7168
Preview: https://pr-7184.pfe-preview.zooniverse.org/lab/1966/workflows/3834?env=staging

This PR updates the Survey Task in the Project Builder, changing some text and options under the "thumbnails" section. Of note, we no longer list the "show small thumbnails" option.

Testing

Testing methods:

• View any test project with a Survey Task.
• Confirm that the changes in the Thumbnails

Status

Ready for review.

Please observe the following warnings, as this may require input from the project management side of things, and possibly some retroactive database-updating follow ups:

• ⚠️ ❗ This change will affect both FEM and PFE labs. If we ONLY want to affect FEM-compatible projects (i.e. project.experimental_tools.femLab = true), then please let me know.
• ⚠️ Any existing project that has anySurveyTask.thumbnails = 'show' will continue to have that thumbnail setting in the database. If they view the page Survey Task editor, they will see it as "default".

[coveralls]

coverage: 56.725% (+0.008%) from 56.717%
when pulling c7974f5 on fix-7168
into 8036774 on master.

[shaunanoordin]

Note about backwards-compatibility: if we want to correctly display the "Show" option for existing projects that still have thumbnails = 'show', then we can change the code here to look something like...

{if @props.task.thumbnails is "show" then
  <option value="show">Show</option>
}

This means the "show" option correctly displays if and only if the Survey Task already has it set that way. As soon as the Survey Task changes to default or hide, the "show" option disappears.

[seanmiller26]

Since we are not making use of the space saving show small option, we no longer have to have a cut-off to show/hide tumbnails. Therefore I think its ok to go ahead with these two view options:

Show - Always show thumbnails (Default)
Hide - Always hide thumbnails

Link to related discussion: https://zooniverse.slack.com/archives/C0Z7YNTSL/p1725640926844379

[seanmiller26]

@goplayoutside3 @lcjohnso I'd like to hear thoughts on this change also affecting PFE projects. I'm leaning towards only FEM since this design focuses on those specific projects, and not PFE.

[goplayoutside3]

I think this change should only affect FEM projects because we're only making UI changes to the FEM classifier.

However, after re-reading the linked Issue and item in the FEM Planning Spreadsheet, I thought the original intention was to change thumbnail options for FEM projects to simply "Yes" or "No". This PR assumes the UI will still auto-hide thumbnails when options > 30, which I assume is why the third "always show small thumbnails" currently exists.

In the scenario where lab options for thumbnails is simply "Yes" or "No", the size of the thumbnails is handled by FEM code, and the decision of whether to show thumbnails is handed over completely to project teams. Is the decision to make the lab options "No" or "Default" documented somewhere?

[seanmiller26]

Agree with you @goplayoutside3 the options should be a Yes, show or No, don't show (see above comment). The FEM spreadsheet was not updated as I was waiting on more comments or opinions, especially from @lcjohnso. Happy to update once we've reached an agreement.

[lcjohnso]

Questions:

• I support binary yes/no setting. What will be default behavior? Yes (i.e., show thumbnails)?
• How would current 3-option configurations map into the new binary configuration?
• If the behavior will only apply to FEM, then should this move to FEMLab (and new workflow editor)?
• Combining the two above: in the future, if we migrate a project from PFE to FEM, what happens to this thumbnails setting?
  • Would it be simpler to change the survey thumbnail configuration platform-wide instead?

Apologies to @shaunanoordin -- should we sort out the solution in the issue and get back to you with final implementation instructions?