Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages Editor: Cleanup #7135

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Pages Editor: Cleanup #7135

wants to merge 1 commit into from

Conversation

shaunanoordin
Copy link
Member

PR Overview

Part of: Pages Editor MVP project and FEM Lab super-project
Follows #7129
Staging branch URL: https://pr-????.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging

This PR is a cleanup for all the tech debt I've accrued over the rapid(-ish?) development of the Pages Editor feature. On the list of things to be done:

  • README to be updated.
  • Comments to be updated.
  • Unused code to be excised and exorcised.
  • Strings to be consolidated into strings.json, for future localisation.
  • Linting? Linting.
  • Tests? Maybe.

Status

WIP.

@shaunanoordin shaunanoordin marked this pull request as draft June 27, 2024 18:00
@coveralls
Copy link

Coverage Status

coverage: 56.948%. remained the same
when pulling d0eb8a6 on pages-editor-pt27
into 4af77a2 on master.

@eatyourgreens
Copy link
Contributor

If the new editor depends on the Panoptes JS Client, then you probably want to upgrade to superagent 9, zooniverse/panoptes-javascript-client#243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants