build(deps): remove babel-plugin-transform-es2015-modules-commonjs #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
from
48f2cba
to
1f23f09
Compare
eatyourgreens
commented
May 31, 2024
| @@ -125,7 +124,7 @@ | |||
| "start": "export NODE_ENV=development; check-engines && check-dependencies && webpack-dashboard -p 3736 -- webpack-dev-server --config ./webpack.dev.js", | |||
| "_build": "export HEAD_COMMIT=$(git rev-parse --short HEAD); check-engines && check-dependencies && rimraf dist; webpack --config ./webpack.build.js --progress --color", | |||
| "build-production": "export NODE_ENV=production; npm run _build", | |||
| "serve-static": "export NODE_ENV=staging; check-engines && check-dependencies && npm run _build && node ./static-server.js", | |||
| "serve-static": "npm ci; export NODE_ENV=production; check-engines && check-dependencies && npm run _build && node ./static-server.js", | |||
There was a problem hiding this comment.
Noting here that staging is an invalid value for NODE_ENV in modern Webpack builds. See https://webpack.js.org/configuration/mode/.
eatyourgreens
commented
May 31, 2024
| @@ -1,6 +1,7 @@ | |||
| module.exports = function (api) { | |||
| api.cache(true); | |||
| return { | |||
| sourceType: 'module', | |||
There was a problem hiding this comment.
See https://babeljs.io/docs/options#sourcetype. ESM is the default for Babel 7.
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
from
b30e4d8
to
af569f2
Compare
eatyourgreens
commented
May 31, 2024
| <Route path=':locale'> | ||
| {SLUGS.map(slug => <MonorepoRoute path={slug} />)} | ||
| {SLUGS.map(slug => <MonorepoRoute key={slug} path={slug} />)} |
There was a problem hiding this comment.
Not really related to the other changes here, but the missing key warnings made real React errors harder to spot while I was chasing down a couple of bugs in this PR. So this makes the console a little bit less noisy.
There was a problem hiding this comment.
#7116 also got in the way of debugging React errors on this branch, so I might fix that here too.
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
2 times, most recently
from
69e5fef
to
7d711bd
Compare
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
from
7d711bd
to
6df9cd8
Compare
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
3 times, most recently
from
6e99494
to
354fd0f
Compare
Remove `babel-plugin-transform-es2015-modules-commonjs`, which is 6 years out-of-date and no longer supported. It generates security warnings in the console, because of outdated dependencies on `babel-traverse` (also 6 years out-of-date and unsupported.) - transpile `.coffee` and `.cjsx` files from CJS to ESM with Babel. - fix broken `module.exports` in a couple of places. - `npm audit fix`.
eatyourgreens
force-pushed
the
remove-babel-cjs-plugin
branch
from
354fd0f
to
7691256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
babel-plugin-transform-es2015-modules-commonjs, which is 6 years out-of-date and no longer supported. It generates security warnings in the console, because of outdated dependencies onbabel-traverse(also 6 years out-of-date and not supported in Babel 7.).coffeeand.cjsxfiles from CJS to ESM.module.exportsin a couple of places.propTypesin Pages Editor components.npm audit fix.You can test this locally a couple of ways:
npm start: development React build with hot module reloading and React debugging errors in the console.npm run serve-static: build the production bundle with Webpack, and serve it onhttp://localhost:3735orhttp://local.zooniverse.org:3735. This method reproduces a production deploy, but without the nginx reverse proxy.npm auditandnpm cishould show 0 problems, with the changes here.Required Manual Testing
Review Checklist
npm ciand app works as expected?Optional
ChangeListenerorPromiseRenderercomponents with code that updates component state?