Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty IOException try-catch handling when extracting PostgreSQL binaries #136

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Remove empty IOException try-catch handling when extracting PostgreSQL binaries #136

merged 1 commit into from
Sep 27, 2024

Conversation

turbanoff
Copy link

Exception is already handled by outer try-catch block.
Ignoring exceptions is bad practice.

@tomix26 tomix26 merged commit 2f830bf into zonkyio:master Sep 27, 2024
6 checks passed
@tomix26
Copy link
Collaborator

tomix26 commented Sep 27, 2024

@turbanoff Thank you for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbanoff @tomix26