Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update dependencies #135

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

reneleonhardt
Copy link

@reneleonhardt reneleonhardt commented Jul 13, 2024

Updates

  • Update dependencies and plugins
  • Test against newer Java versions and remove outdated ones
  • Update GitHub Actions
  • Let Dependabot update Maven and GitHub Actions

Fixes

  • Default LC_ALL for Unix (otherwise initidb fails), my Mac has nothing set 😅

Improvements

Recommendations

  • Upgrade maven-gpg-plugin and check release

@tomix26
Copy link
Collaborator

tomix26 commented Jul 14, 2024

Thank you very much for you contribution. At first glance the code looks very good, but I need to look at it in more detail. I will do it as soon as I can. Probably within the next week.

@Crystark
Copy link

Great job there on the POM. Thanks for your work @reneleonhardt. Looking forward to using this.

@reneleonhardt
Copy link
Author

Yeah, it wasn't easy to build on Apple Silicon, never had to use this profile trick before 😅
Had to rebuild many times to test all the different combinations... if you can, extend your test matrix by building on ARM and Windows too, at least for the happy path.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@tomix26
Copy link
Collaborator

tomix26 commented Aug 6, 2024

@reneleonhardt Do you plan to incorporate the suggested changes? If you don't mind, I could do that and finish the pull request.

@reneleonhardt
Copy link
Author

@reneleonhardt Do you plan to incorporate the suggested changes? If you don't mind, I could do that and finish the pull request.

It's your project, you can do what you want, I'm glad that you at least plan to merge my work 😅 👍

@reneleonhardt
Copy link
Author

reneleonhardt commented Aug 6, 2024

I updated some more dependencies (my last updates were a month ago, so of course there already were a dozen more updates 😅).
Could you start the test workflow? It seems not to be configured to run automatically in your PRs.

Isn't it possible to update embedded-postgres-binaries to 16, it has to stay on 14?
Postgres 17 is only two months away...

@tomix26
Copy link
Collaborator

tomix26 commented Aug 6, 2024

I updated some more dependencies

Great, I like it.

It seems not to be configured to run automatically in your PRs

It should run automatically, but not when there are changes in GitHub workflows.

Isn't it possible to update embedded-postgres-binaries to 16

This is also a potentially backwards incompatible change. So I would rather change it in the next major version.

@reneleonhardt
Copy link
Author

Isn't it possible to update Flyway 7 to 9? 2 years newer and fewer security vulnerabilities...
https://mvnrepository.com/artifact/org.flywaydb/flyway-core

@tomix26
Copy link
Collaborator

tomix26 commented Aug 7, 2024

Isn't it possible to update Flyway 7 to 9? 2 years newer and fewer security vulnerabilities... https://mvnrepository.com/artifact/org.flywaydb/flyway-core

Ok, great idea, let's do it. We could also update liquibase-core. Both libraries are optional dependencies, so updating them should be safe.

I would propose the following versions:

  • flyway-core: 9.22.3
  • liquibase-core: 4.24.0

After this change, I'm going to merge the pull request.

@tomix26
Copy link
Collaborator

tomix26 commented Aug 7, 2024

I've just noticed that you've already updated liquibase-core. The major version is still the same, so let's keep the latest version there.

@tomix26 tomix26 merged commit e61945b into zonkyio:master Aug 7, 2024
6 checks passed
@reneleonhardt
Copy link
Author

Oh, I didn't know that you didn't want to squash, that's not a meaningful commit history... 😢
Please test everything if you can, thank you for merging!

@tomix26
Copy link
Collaborator

tomix26 commented Aug 7, 2024

Don't worry, this project isn't so big yet that a few commits would cause any problems 🙂

Thank you very much for all your effort. I really appreciate it.

It's great to see others contributing to the project.

@tomix26 tomix26 added this to the 2.1.0 milestone Aug 7, 2024
@reneleonhardt
Copy link
Author

You're welcome, feels good to be appreciated, most projects don't allow any updates or security fixes.
Thank you for providing the best database as an embedded process, I hope we can make the developer experience and performance as good as possible to become a superior alternative to testcontainers (which JDBC and Postgres support is awful in my experience) 😄

@reneleonhardt
Copy link
Author

reneleonhardt commented Aug 17, 2024

@tomix26 I'm trying to update zonkyio/embedded-database-spring-test#279 too which isn't easier when tests are not running locally... can you tag 2.1.0?

@tomix26
Copy link
Collaborator

tomix26 commented Aug 19, 2024

If you mean releasing a new version, I'll try to do that during this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.0.7 includes conflicting dependency versions
3 participants