Use camlzip
package to implement a ZipStore
.
#90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recently reading the licensing terms
camlzip
, I realized that although it is licensed under LGPL, it contains a special exception that allows library authors to link to camlzip without being bound to the licensing terms of LGPL. The exception reads:I was initially not aware of this exception in the license and that drove the decision to implement ZipStore using
zipc
(which reads an entire zip archive into memory). This commit replaceszipc
withcamlzip
and as a result re-works theZipStore
implementation.