Fix missing optional key warnings when AllPatternsMandatory is enabled. #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All Optional params that are missing should be shown.
- isEqualToNormalizingWhitespace instead of containsIgnoringWhitespaces when possible, so anything additional is caught.
StarKhan6368
force-pushed
the
mandatory-patterns-fixes
branch
from
5fdc129 to
d66503f
Compare
joelrosario
requested changes
Jan 17, 2025
- AnyPattern should not add itself as seen as the discriminator mappings can ref back to itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix missing optional key warnings when AllPatternsMandatory is enabled.
Why:
How:
Checklist: