-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add codespell integration #2642
base: main
Are you sure you want to change the base?
Conversation
Configure this typo finding and fixing tool, and address problems detected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to have this for docs, thanks. For the rest (dts and C comments) I'll defer to others.
Apply feedback from PR comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll give a formal approval for the docs changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mostly just one comment/question on this.
@@ -0,0 +1,4 @@ | |||
[codespell] | |||
skip = docs/package-lock.json,*.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to ignore the regular package.json
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, no.
Those files are there just because they threw some error, thus i whitelisted them... There might be some other "special" files we want to ignore too.
As per title/commit, very tiny changes :)