Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add codespell integration #2642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elpekenin
Copy link
Contributor

As per title/commit, very tiny changes :)

Configure this typo finding and fixing tool, and address problems detected
@elpekenin elpekenin requested review from a team as code owners November 13, 2024 15:46
@caksoylar caksoylar added documentation Improvements or additions to documentation chore labels Nov 13, 2024
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to have this for docs, thanks. For the rest (dts and C comments) I'll defer to others.

docs/docs/config/battery.md Outdated Show resolved Hide resolved
Apply feedback from PR comments
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll give a formal approval for the docs changes.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly just one comment/question on this.

@@ -0,0 +1,4 @@
[codespell]
skip = docs/package-lock.json,*.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to ignore the regular package.json as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, no.

Those files are there just because they threw some error, thus i whitelisted them... There might be some other "special" files we want to ignore too.

@petejohanson petejohanson self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants