-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat(boards)!: refactor common layouts #2517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, seeing this in practice.... I really do like the fact that boards/shields can just explicitly import the layouts they want and run with it. The splitting up of the position map makes it perhaps a tiny bit harder to grok, but also is cohesive with everything for a given specific layout in the same file. I'd say we go with this, unless @ReFil has any concerns after their initial work on this.
I like this implementation, I can foresee it saving a lot of confusion when module developers are unsure whether or not to include |
9c8dd43
to
bc6c335
Compare
I think this is ready for review now. I checked that all the position maps make sense by pasting all the files for each layout together into https://zmk-layout-helper.netlify.app/, but I haven't tested that every board builds yet. |
Could you split the corne layout as well? |
bc6c335
to
f5b4117
Compare
I didn't notice that there were multiple layouts there before. Done. |
Removed the combined .dtsi file for each group of common layouts, and split the position map across the files in each group. This makes reading the position maps slightly more difficult, but it aligns the common layouts with the keyboard-specific ones such as foostan/corne.dtsi in that simply including each header adds the layout, with no need to set status = "okay".
Looks like there are more things for me to update since the commit where I started this branch. |
Split up the Corne layout files to match the previous commit.
f5b4117
to
d129930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed an issue introduced in zmkfirmware#2517 where the corneish_zen boards weren't updated. Fixes zmkfirmware#2530.
Removed the combined .dtsi file for each group of common layouts, and split the position map across the files in each group. This makes reading the position maps slightly more difficult, but it aligns the common layouts with the keyboard-specific ones such as foostan/corne.dtsi in that simply including each header adds the layout, with no need to set status = "okay".