Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic metadata info to new behavior guide. #2506

Conversation

petejohanson
Copy link
Contributor

No description provided.

@petejohanson petejohanson added documentation Improvements or additions to documentation behaviors labels Sep 26, 2024
@petejohanson petejohanson self-assigned this Sep 26, 2024
@petejohanson petejohanson requested a review from a team as a code owner September 26, 2024 07:10
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
@petejohanson petejohanson force-pushed the docs/add-basic-behavior-metadata-docs branch 3 times, most recently from f1e3ed6 to 1689f96 Compare September 30, 2024 19:53
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
@petejohanson petejohanson force-pushed the docs/add-basic-behavior-metadata-docs branch from 78624ab to ebb2e64 Compare October 7, 2024 22:04
Copy link
Contributor Author

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed everyone's code review. Thanks!

docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/docs/development/new-behavior.mdx Outdated Show resolved Hide resolved
Co-authored-by: Cem Aksoylar <[email protected]>
Co-authored-by: Nicolas Munnich <[email protected]>
@petejohanson petejohanson force-pushed the docs/add-basic-behavior-metadata-docs branch from 3391f2b to 0960490 Compare October 8, 2024 06:38
@petejohanson petejohanson merged commit 6cac781 into zmkfirmware:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants