-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add basic metadata info to new behavior guide. #2506
Merged
petejohanson
merged 1 commit into
zmkfirmware:main
from
petejohanson:docs/add-basic-behavior-metadata-docs
Oct 8, 2024
Merged
feat: Add basic metadata info to new behavior guide. #2506
petejohanson
merged 1 commit into
zmkfirmware:main
from
petejohanson:docs/add-basic-behavior-metadata-docs
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
documentation
Improvements or additions to documentation
behaviors
labels
Sep 26, 2024
joelspadin
requested changes
Sep 27, 2024
petejohanson
force-pushed
the
docs/add-basic-behavior-metadata-docs
branch
3 times, most recently
from
September 30, 2024 19:53
f1e3ed6
to
1689f96
Compare
caksoylar
reviewed
Sep 30, 2024
Nick-Munnich
reviewed
Oct 4, 2024
petejohanson
force-pushed
the
docs/add-basic-behavior-metadata-docs
branch
from
October 7, 2024 22:04
78624ab
to
ebb2e64
Compare
petejohanson
commented
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed everyone's code review. Thanks!
caksoylar
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Cem Aksoylar <[email protected]> Co-authored-by: Nicolas Munnich <[email protected]>
petejohanson
force-pushed
the
docs/add-basic-behavior-metadata-docs
branch
from
October 8, 2024 06:38
3391f2b
to
0960490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.