app: cmake: use $ENV{ZEPHYR_BASE} as hint #1941
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the common way to do this and has the advantage that it works when the zephyr repo is an a different location and was not registered in the users cmake registry - which is a very common usecase supported by zephyr. You end up with that by `west init`-ing the git url of either the zmk repo directly or another manifest repo which imports the zmk repo. This is more convenient than the whole manual `west init -l` stuff. This works because west automatically exports the `ZEPHYR_BASE` environment variable to all extensions - including `west build`. For that exact reason it should not break anyones scripts unless they're using cmake directly and didn't set the $ZEPHYR_BASE environment variable.
|
I'm a tad wary to do this, as it forces setting that, which IIRC, we had issues with previously, which is why we moved to the relative directory version as found here. |
|
I can't find any documentation of these issues since it's basically been in git forever. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the common way to do this and has the advantage that it works when the zephyr repo is an a different location and was not registered in the users cmake registry - which is a very common usecase supported by zephyr. You end up with that by
west init-ing the git url of either the zmk repo directly or another manifest repo which imports the zmk repo. This is more convenient than the whole manualwest init -lstuff.This works because west automatically exports the
ZEPHYR_BASEenvironment variable to all extensions - includingwest build. For that exact reason it should not break anyones scripts unless they're using cmake directly and didn't set the $ZEPHYR_BASE environment variable.