Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviung53 shield definition #1937

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Reviung53 shield definition #1937

merged 7 commits into from
Oct 17, 2023

Conversation

kh411d
Copy link
Contributor

@kh411d kh411d commented Sep 19, 2023

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • [n/a] If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the suggestions I noted below, can you update the copyright header dates on all files?

app/boards/shields/reviung53/reviung53.keymap Outdated Show resolved Hide resolved
app/boards/shields/reviung53/reviung53.keymap Outdated Show resolved Hide resolved
@caksoylar caksoylar added the shields PRs and issues related to shields label Sep 25, 2023
@kh411d
Copy link
Contributor Author

kh411d commented Sep 26, 2023

Change addressed, copyright date updated, keymap indentation adjusted.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 7fe9ecd into zmkfirmware:main Oct 17, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants