Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Underglow): Momentary effect selection #1457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented Sep 13, 2022

Adds the ability to have an RGB effect select whilst held down and revert when released.

Designed to be used in conjunction with #1456 to allow for momentary battery indication through the lighting by holding down a specific key

@ReFil ReFil requested a review from a team as a code owner October 18, 2023 09:12
@ReFil ReFil force-pushed the rgb-momentary-eff branch from 65834d9 to 9e9b5f5 Compare October 18, 2023 09:19
@ReFil
Copy link
Contributor Author

ReFil commented Oct 18, 2023

I've edited the documentation to note the new command as well as notes around an edge case when it's powered off with the key held down. Thinking about this I've realised the functionality can now be done using a parameterised macro too, however i think a dedicated behaviour command still has value. A parameterised macro would also present the same issue on the edge case when it's powered off with the key held down, I cant think of a good way to mitigate this (If anyone has ideas i'm happy to implement them)

@caksoylar
Copy link
Contributor

I think the macro approach would hit #1494 as well, and I assume this works without issues for splits.

@ReFil
Copy link
Contributor Author

ReFil commented Oct 18, 2023

I'll double check, a variant of this has been in use on the 360 Pro but the 360 pro doesn't use the standard locality implementation

docs/docs/behaviors/underglow.md Outdated Show resolved Hide resolved
docs/docs/behaviors/underglow.md Outdated Show resolved Hide resolved
docs/docs/behaviors/underglow.md Outdated Show resolved Hide resolved
docs/docs/behaviors/underglow.md Outdated Show resolved Hide resolved
@ReFil ReFil force-pushed the rgb-momentary-eff branch from 30cd263 to 1407829 Compare October 23, 2023 12:04
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit on the formatting in the table.

docs/docs/behaviors/underglow.md Outdated Show resolved Hide resolved
@ReFil ReFil force-pushed the rgb-momentary-eff branch 2 times, most recently from 1076b7e to 829b75b Compare March 22, 2024 09:32
@ReFil ReFil force-pushed the rgb-momentary-eff branch from 2f600a7 to d1b98ea Compare June 18, 2024 17:51
@ReFil
Copy link
Contributor Author

ReFil commented Jul 16, 2024

Studio metadata has now been added. I think I've done it right but would appreciate someone more knowledgeable on the metadata looking over it

Adds the ability to have an RGB effect select whilst held down and revert when release
@ReFil ReFil requested a review from a team as a code owner September 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants