Fix --dnssec and add a test (#442)

* fixed dnssec record fetching

* added dnssec fetching smoke test

* lint

src/zdns/lookup.go

@@ -191,13 +191,7 @@ func (r *Resolver) followingLookup(ctx context.Context, q Question, nameServer *
 
 		// populateResults will parse the Answers and update the candidateSet, cnameSet, and garbage caching maps
 		populateResults(res.Answers, q.Type, candidateSet, cnameSet, dnameSet, garbage)
-		for _, ans := range res.Answers {
-			answer, ok := ans.(Answer)
-			if !ok {
-				continue
-			}
-			allAnswerSet = append(allAnswerSet, answer)
-		}
+		allAnswerSet = append(allAnswerSet, res.Answers...)
 
 		if isLookupComplete(originalName, candidateSet, cnameSet, dnameSet) {
 			return &SingleQueryResult{

testing/integration_tests.py

@@ -1351,6 +1351,19 @@ def test_a_lookup_IP_name_server_with_input_flag_loopback_mismatch(self):
         self.assertEqual(res["results"]["A"]["data"]["resolver"], "8.8.8.8:53", "user-supplied name server with input "
                                                                                 "should take precedence")
 
+    def test_dnssec_option(self):
+        c = "A --dnssec --name-servers=1.0.0.1"
+        name = "cloudflare.com"
+        cmd, res = self.run_zdns(c, name)
+        self.assertSuccess(res, cmd, "A")
+        hasRRSIG = False
+        for record in res["results"]["A"]["data"]["answers"]:
+            if record["type"] == "RRSIG":
+                hasRRSIG = True
+                break
+        self.assertTrue(hasRRSIG, "DNSSEC option should return an RRSIG record")
+
+
 
 
 if __name__ == "__main__":