Simplify OptionalWrapper #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't worry, you're doing great. Usually, I wouldn't want to make low-value changes that break public APIs, but I don't think macro_helpers really counts as a public API per se, so I'm fine with it in this case. I'll just handwave and pretend it's not public :P |
- We never use `self`, so there is no need to pass it as a parameter... - ... which then removes the need to instanciate the wrapper with `new` - There is no reason to expect other type than `Option` so we can contrain the trait to the type directly instead of using the `IsOption` trait
|
On second thought, I'll keep this around as a breaking change for next time we do a semver-major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That commit is based on Label collection fixes and cleanup #343 to avoid conflicts. But Github doesn't supports stacked PR across forks, so for now, it includes Label collection fixes and cleanup #343 as well. Just look at the last commit for the actual change.
I'm new to Rust and there are sometimes subtilties that escape me. So maybe it's not quite identical code. All the unit tests pass at least.
I don't know how you feel about minor changes like that. I would totally understand if you think it's a pointless/unnecessary one.