Implemented a simple steps-based example #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
reviewed
Jul 23, 2022
There was a problem hiding this comment.
This is excellent! Thank you for taking the time to do this. This example is fantastic and really shows how this stuff is expected to work really clearly, imo.
If you want to add more comments, I think that's a great idea and I'll wait for that.
Also, it would be nice if you added something to the README about available examples so people know where to look.
|
@zkat There we go. Ready to merge if you are. |
|
Wait, right the readme, one moment |
|
There we go |
zkat
approved these changes
Jul 24, 2022
zkat
pushed a commit
that referenced
this pull request
Aug 1, 2022
Co-authored-by: Werner Kroneman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I tried writing a simple example to document (#28) how to compose two actions together.
Documenting comments aren't quite there yet (kinda ran into my bedtime), but I did run it, and variables appear to change as they should.
Can you take a look to see if this is the kind of set-up you had in mind? I'll go through it and document stuff tomorrow.