Skip to content

Retire the unreachable multi-signal brief descriptor family - #1033

Merged
zkWizard merged 3 commits into
mainfrom
codex/editor-prune-dead-lib-20260818-1500
Aug 18, 2026
Merged

Retire the unreachable multi-signal brief descriptor family#1033
zkWizard merged 3 commits into
mainfrom
codex/editor-prune-dead-lib-20260818-1500

Conversation

@zkWizard

Copy link
Copy Markdown
Owner

Rung 2 — shrink the dead library. Twenty-one src/lib modules and their 21 test
files, removed whole.

Visible: none — dead code removal. The wired module count is unchanged at
147 and every bundle chunk is byte-comparable; src/lib goes 293 → 272
modules and 146 → 125 unreachable.

What this family was

All 21 sit downstream of environmentBrief.ts: a "provenance-first property
descriptor for a multi-signal environment brief" set built 2026-07-13 → 07-28,
plus the brief* synthesis layer above it and its entry point,
placeObservationBrief.ts. The entry point was itself never wired, so
nothing beneath it could reach the app — the whole subtree has been staged since
the week it was written.

environmentBrief.ts itself stays: five wired modules (coverageAdequacy,
briefValuePrecision, spatialSupport, briefValueUncertainty,
observationModality) import its types.

Deleted modules

Descriptor set: measurementScale, observingSystem, signalCompartment,
signalReferenceFrame, spatialExtensivity, processingLevel,
registrantProvenance, unitCommensurability, sourceIndependence,
observationRecency, observabilityGating, coObservedCoverage,
citationConsistency.

Synthesis layer: briefDigest, briefCitationBundle, briefCoObservation,
briefCurrency, briefLegendSaturation, briefRecordDepth,
briefSourceIndependence.

Entry point: placeObservationBrief.

Each .ts came with a matching .test.ts; both went. Git history preserves
every one — resurrect deliberately if a wired consumer ever wants it.

Why these and not the other 125

Three near neighbours were kept deliberately, each blocked by exactly one
edge, so this stays a pure deletion with no test or doc edits:

  • citationCompleteness — imported by briefProvenanceIntegrity, which is 7
    days old and therefore protected.
  • quantityKind, temporalAggregation — asserted by methods-doc.test.ts;
    removing them would mean editing a test's assertions and the doc behind it.
  • signalDomain — type-imported by the wired atmosphereProbeDomain.

Not touched: the multi-year descriptor families (percentiles, SPI, seasonal
baselines, record margins, seasonal cycles/harmonics across air temperature,
precipitation, ocean, aerosol, phenology, snow, seismic). Those are the
environmental scientist's approved series-fetch arc — they are staged because
the place panel samples a two-month pair, not because they are abandoned, and
the shared multi-month series fetch is meant to wire them.

Conditions checked, all 21

Unreachable per node scripts/walk-wired.mjs (regenerated this run, not a
stale list) · last commit 21–36 days ago · absent from all four open PRs
(#1031, #1029, #1027, #959) · no reference anywhere in docs/, e2e/,
comms/, scripts/ or README.md · no surviving file in the repo imports
any of them
(verified by resolving every relative import in the tree, not by
grep).

Deltas

  • Source: −5,795 lines (21 files)
  • Tests: −5,067 lines (21 files)
  • With tests: −10,862 lines, 0 added.

Gates

npx tsc --noEmit clean · npm test 295 files / 4,534 tests passed (was
316 / 4,701 — the delta is the 21 removed test files) · npm run build every
chunk ok, zero FAIL, total JS 288.5 kB gzip · prettier not applicable, no
file was modified. Full local e2e not run: no source file changed, so no panel,
DOM or copy behaviour can differ — the required E2E smoke (WebGL) job covers
it on CI.

🤖 Generated with Claude Code

zkWizard and others added 3 commits August 18, 2026 10:02
Twenty-one src/lib modules and their tests, none reachable from the
shipped bundle, all last touched 21-36 days ago, none referenced by any
open PR, doc, script or e2e spec.

They are the descriptor set built on top of environmentBrief in
mid-July: a "provenance-first <property> descriptor for a multi-signal
environment brief" family plus the brief* synthesis layer and its
entry point, placeObservationBrief. The entry point itself was never
wired, so nothing downstream of it could be.

This is a separate arc from the environmental scientist's multi-month
series fetch, which unblocks the multi-year descriptor families
(percentiles, SPI, seasonal baselines, record margins). Those are
untouched.

Pure deletion: no surviving file imports any removed module, so no
test, doc or source edit accompanies it. src/lib goes 293 -> 272
modules and 146 -> 125 unreachable; wired count is unchanged at 147.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@zkWizard
zkWizard merged commit 25dff9e into main Aug 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant