Skip to content

test: Switch to GitHub actions#515

Merged
bf4 merged 3 commits intozipmark:masterfrom
x-b-e:switch_to_github_actions
Apr 25, 2024
Merged

test: Switch to GitHub actions#515
bf4 merged 3 commits intozipmark:masterfrom
x-b-e:switch_to_github_actions

Conversation

@bf4
Copy link
Copy Markdown
Contributor

@bf4 bf4 commented Apr 25, 2024

per discussion in #507 (comment)

I don't think we can test running this until it's merged. I'm happy to address any failures until then

since #461

Comment thread .github/dependabot.yml
directory: "/"
schedule:
# Check for updates to GitHub Actions every weekday
interval: "daily"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you'll want weekly for this?

Comment thread .github/dependabot.yml
- package-ecosystem: bundler
directory: "/"
schedule:
interval: daily
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you'll want weekly for this?

Comment thread .github/workflows/ci.yml
# Failing with a stack trace in active support
# - ruby-version: '2.4'
# rails-version: '4.1'
# bundler: '1'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis ci had

  - 2.1.8
  - 2.2.4
  - 2.3.0
  - 2.4.9
  - 2.5.8
  - 2.6.6

Comment thread .github/workflows/ci.yml
bundler: "${{ matrix.bundler || 2 }}"
bundler-cache: true
# env:
# RAILS_VERSION: ${{ matrix.rails-version }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we decide to install certain versions of active support, this is an easy pattern for doing that

Comment thread .github/workflows/ci.yml

# - name: Install required libs
# run: |
# sudo apt-get -yqq install libsqlite3-dev
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we need to install any dependencies, this is an easy pattern for doing that

Comment thread README.md
@@ -1,4 +1,3 @@
[![Build Status](https://travis-ci.org/zipmark/rspec_api_documentation.svg?branch=master)](https://travis-ci.org/zipmark/rspec_api_documentation)
[![Code Climate](https://codeclimate.com/github/zipmark/rspec_api_documentation/badges/gpa.svg)](https://codeclimate.com/github/zipmark/rspec_api_documentation)
[![Inline docs](https://inch-ci.org/github/zipmark/rspec_api_documentation.svg?branch=master)](https://inch-ci.org/github/zipmark/rspec_api_documentation)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inch looks like it's dead

@jakehow
Copy link
Copy Markdown
Member

jakehow commented Apr 25, 2024

@bf4 I gave you commit bit so you can manage this

@bf4 bf4 merged commit 6b721af into zipmark:master Apr 25, 2024
@bf4 bf4 deleted the switch_to_github_actions branch April 25, 2024 17:38
@bf4
Copy link
Copy Markdown
Contributor Author

bf4 commented Apr 25, 2024

Great! I'll test how this goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants