Make benchmarks more accurate #1484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvanoosten
force-pushed
the
simulate-network
branch
from
fcc5f2b to
cf554d7
Compare
svroonland
approved these changes
Feb 22, 2025
Yes, that is correct. |
erikvanoosten
force-pushed
the
simulate-network
branch
2 times, most recently
from
a4eab98 to
2656123
Compare
... by adding a 5ms delay in each call to the underlying java consumer. This solves the problem that the embedded kafka broker can respond virtually immediately, while in reality there is almost always a network hop. Since the calls of the underlying java consumer do not correspond 1:1 to network traffic, this is a crude approximation. Nevertheless, we expect that redundant consumer calls will become visible in the benchmarks. Also: remove a duplicate benchmark.
erikvanoosten
force-pushed
the
simulate-network
branch
from
2286df1 to
3c65ec1
Compare
svroonland
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by adding a 5ms delay in each call to the underlying java consumer. This solves the problem that the embedded kafka broker can respond virtually immediately, while in reality there is almost always a network hop.
Since the calls of the underlying java consumer do not correspond 1:1 to network traffic, this is a crude approximation. Nevertheless, we expect that redundant consumer calls will become visible in the benchmarks.
Also: remove a duplicate benchmark.