Skip to content

fix: respect Accept header in content negotiation #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: respect Accept header in content negotiation #3460

wants to merge 1 commit into from

Conversation

Ayush9026
Copy link

This PR fixes content-type negotiation when clients request text/plain responses.

/claim #3284

Changes:

  • Modified content negotiation to properly respect Accept headers
  • Ensured consistent behavior between success and error responses
  • Added test cases for content negotiation scenarios

Fixes:

Testing:

  • Verified text/plain responses when requested
  • Confirmed JSON remains default when no Accept header
  • Verified error responses respect content type

@algora-pbc algora-pbc bot mentioned this pull request Apr 13, 2025
Open
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@987Nabil 987Nabil closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes Awaiting requested review from jdegoes jdegoes is a code owner

@vigoo vigoo Awaiting requested review from vigoo vigoo is a code owner

@kyri-petrou kyri-petrou Awaiting requested review from kyri-petrou kyri-petrou is a code owner

@987Nabil 987Nabil Awaiting requested review from 987Nabil 987Nabil is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayush9026 @CLAassistant @987Nabil