Make QueryParams#unsafeQueryParam return null for missing key (#3441) #3445
Conversation
| underlying.get(key).get(0) | ||
| override private[http] def unsafeQueryParam(key: String): String = { | ||
| val value = underlying.get(key) | ||
| if (value == null) null else value.get(0) |
There was a problem hiding this comment.
given that this is a list, you are still open to throwing a null pointer.
There was a problem hiding this comment.
Why? If it is null, I return null. If it is the empty list, get 0 returns null. That is the behaviour I want. Did I miss something?
There was a problem hiding this comment.
sorry i meant that on value.get(0). we may want a check around that.
edit:
sorry did you say .get(0) would return null on an empty list? Wouldnt it return out of bounds?
|
there were tests in the initial PR that were closed. to be safe, we should probably include them too. |
|
The tests already exists in the RoundtripSpec. It was green, because the value was added when it is encoded as null. Now it is not added, and without the fix in QueryParams it fails |
Only add parameters if not encoded as null
987Nabil
force-pushed
the
fix-query-encoding-decodeing
branch
from
c196f61 to
b207c4d
Compare
fixes #3441