Added Step Back and Restart feature #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to jump back to the last frame or restart the visualization with a button. Name changes: Step: >> Step back: <<
Also added bugfix for number_of_steps
SamTov
requested changes
Jun 13, 2024
There was a problem hiding this comment.
I really like the PR. I do have one critical comment regarding getting the run time as for a static mesh object, this will be 1 which is then wrong for the other meshes. However, overall, really cool job.
If you can fix up the trajectory length (maybe use max instead of min) and make sure the tests are passing, I am happy to merge.
Adapted spacing as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to jump back to the last frame or restart the visualization with a control button.
changed title of step forward button to ">>" and called the Step back button "<<".
Sorted it like "<< Play >>" on a remote control.