Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 #419

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Ruby 3.3 #419

merged 3 commits into from
Sep 26, 2024

Conversation

lvonk
Copy link
Member

@lvonk lvonk commented Sep 4, 2024

No description provided.

Two notable changes:

- `establish_connection` defers actually making the connection until usage. So `active?` no longer returns true after calling `establish_connection`.
- `quote_table_name` is no longer implemented in the module and should
be called on the actual connection.
@lvonk
Copy link
Member Author

lvonk commented Sep 18, 2024

To those interested: we found an issue in our apps connected to cloudhsm of aws after upgrading to ruby 3.3. Openssl 3 deprecated the usage of engines and by default ruby does not enable them anymore.
OpenSSL::Engine support need to be explicitly enabled by setting the compiler flag RUBY_CFLAGS=-DOSSL_USE_ENGINE (in rbenv in our case)...
So waiting to merge until this runs in production without errors.

PS this is only related to our specific setup, not related to sequent.

@lvonk lvonk merged commit e8d3921 into master Sep 26, 2024
11 checks passed
@lvonk lvonk deleted the upgrade_to_ruby_3.3 branch September 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants