Skip to content

Conversation

@CLiqing
Copy link

@CLiqing CLiqing commented Oct 29, 2025

Add refine type for IVF_PQ/IVF_SQ
Add sq_type for IVF_SQ, default is SQ8, optional range is [SQ4, Sq6, SQ8]

/kind improvement

@sre-ci-robot
Copy link
Collaborator

Welcome @CLiqing! It looks like this is your first PR to zilliztech/knowhere 🎉

@mergify
Copy link

mergify bot commented Oct 29, 2025

@CLiqing 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

# v2.6 tag is used for cardinal v2
set(CARDINAL_VERSION v2.6.4)
set(CARDINAL_REPO_URL "https://github.com/zilliztech/cardinal.git")
set(CARDINAL_VERSION master)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change v2.6.4 -> master needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change v2.6.4 -> master needed?

Just ignore it. This was automatically added during previous testing using vectool and will be removed in the official version.

@alexanderguzhva
Copy link
Collaborator

@CLiqing there are still problems with UT

@mergify mergify bot added dco-passed and removed needs-dco labels Nov 4, 2025
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CLiqing
To complete the pull request process, please assign cqy123456 after the PR has been reviewed.
You can assign the PR to them by writing /assign @cqy123456 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ChenLiqing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants