-
Notifications
You must be signed in to change notification settings - Fork 112
[Test] Add refine type for IVF_PQ/IVF_SQ #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @CLiqing! It looks like this is your first PR to zilliztech/knowhere 🎉 |
|
@CLiqing 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
f341e9e to
30857aa
Compare
| # v2.6 tag is used for cardinal v2 | ||
| set(CARDINAL_VERSION v2.6.4) | ||
| set(CARDINAL_REPO_URL "https://github.com/zilliztech/cardinal.git") | ||
| set(CARDINAL_VERSION master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change v2.6.4 -> master needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change
v2.6.4->masterneeded?
Just ignore it. This was automatically added during previous testing using vectool and will be removed in the official version.
|
@CLiqing there are still problems with UT |
9e0a6fb to
79c54dc
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CLiqing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ChenLiqing <[email protected]>
Add refine type for IVF_PQ/IVF_SQ
Add sq_type for IVF_SQ, default is SQ8, optional range is [SQ4, Sq6, SQ8]
/kind improvement