Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initialization options #1934

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Support initialization options #1934

merged 2 commits into from
Jul 3, 2024

Conversation

gohryt
Copy link
Contributor

@gohryt gohryt commented Jun 27, 2024

This is needed because of some text editors that does't have support of sending options via i_haz_configuration

@Techatrix
Copy link
Member

Could you clarify which editors this applies to?

@gohryt
Copy link
Contributor Author

gohryt commented Jul 2, 2024

Personally i have this error in zed but i also find that it was in some terminal based editors.
And it's still part of the protocol.

@Techatrix
Copy link
Member

Good to know that Zed uses initializationOptions. Thanks

Techatrix
Techatrix previously approved these changes Jul 2, 2024
gohryt and others added 2 commits July 2, 2024 10:03
The `initialization_options` would previously be ignored if a zls.json
was found.
@Techatrix
Copy link
Member

I noticed that the config options where never de-allocated. The initialization_options would also be ignored if a zls.json was found. I pushed a fix to this PR.

@Techatrix Techatrix merged commit a263b8d into zigtools:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants