Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std.Uri instead of our own code #1671

Merged
merged 1 commit into from
Jul 3, 2024
Merged

use std.Uri instead of our own code #1671

merged 1 commit into from
Jul 3, 2024

Conversation

Techatrix
Copy link
Member

std.Uri provides everything we need to deal with URIs we don't to write everything our self.
A follow-up can then remove the entire uri.zig file.

I will need to verify that this is also working on Windows.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (cfea2d5) to head (cccfda7).

Current head cccfda7 differs from pull request most recent head 4e7417d

Please upload reports for the commit 4e7417d to get more accurate results.

Files Patch % Lines
src/analysis.zig 0.00% 3 Missing ⚠️
src/DocumentStore.zig 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   78.61%   78.42%   -0.20%     
==========================================
  Files          35       34       -1     
  Lines       10837    10575     -262     
==========================================
- Hits         8520     8293     -227     
+ Misses       2317     2282      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Techatrix Techatrix marked this pull request as ready for review January 14, 2024 14:51
@Techatrix Techatrix force-pushed the techatrix/std-uri branch 2 times, most recently from d62461c to fa82d11 Compare February 27, 2024 18:10
@Techatrix Techatrix marked this pull request as draft March 5, 2024 13:22
@Techatrix Techatrix force-pushed the techatrix/std-uri branch 2 times, most recently from f85736d to d7dbd38 Compare May 31, 2024 18:20
Windows has been designed by a group of senile raccoons
@Techatrix Techatrix marked this pull request as ready for review June 19, 2024 15:06
@Techatrix Techatrix merged commit 4408eb2 into master Jul 3, 2024
3 checks passed
@Techatrix Techatrix deleted the techatrix/std-uri branch August 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant