Replace decimals with suggested_display_precision + remove rounding #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #408 +/- ##
==========================================
- Coverage 96.68% 96.68% -0.01%
==========================================
Files 61 61
Lines 9834 9831 -3
==========================================
- Hits 9508 9505 -3
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
reviewed
Mar 31, 2025
| @@ -658,7 +654,7 @@ def formatter(self, value: int) -> int | float: | |||
|
|
|||
| value = float(value * multiplier) / divisor | |||
| if value < 100 and divisor > 1: | |||
| return round(value, self._decimals) | |||
| return round(value, self._attr_suggested_display_precision) | |||
There was a problem hiding this comment.
For the ElectricalMeasurement sensor, we effectively set:
_attr_suggested_display_precision = 1ifdivisor > 1 and value < 100_attr_suggested_display_precision = 0otherwise
Home Assistant caches suggested_display_precision so I don't think we can dynamically change it.
Should we globally set the decimals to 1?
There was a problem hiding this comment.
The default _attr_suggested_display_precision is 1, so keeping the round here as is now will keep it working the same as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.