Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EZSP send lock from EZSP to individual protocol handlers #649

Merged
merged 20 commits into from
Sep 13, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Sep 9, 2024

We recently moved a lot of code into individual EZSP protocol handlers. This introduced a "hole" where protocol handlers could run multiple commands at once within a single semaphore.

This PR moves the semaphore into the protocol handlers, closing this hole. I've also adjusted protocol timeouts to better handle TCP failures, making communication with TCP coordinators a bit more resilient. I think after this PR we may be able to immediately disconnect on watchdog failure as opposed to allowing up to five to fail.

CC @tube0013

bellows/ezsp/protocol.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (e160be2) to head (9f6f286).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #649   +/-   ##
=======================================
  Coverage   99.13%   99.14%           
=======================================
  Files          50       50           
  Lines        3486     3494    +8     
=======================================
+ Hits         3456     3464    +8     
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit 1a0b8a7 into zigpy:dev Sep 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants