Prevent task cancellation from propagating to ASH - #628
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #628 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 75 75
Lines 5002 5016 +14
=======================================
+ Hits 4988 5002 +14
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Contributor
|
2 hours in this is working well, no more NCP failures. |
TheJulianJES
approved these changes
Jun 14, 2024
mineshaftgap
pushed a commit
to mineshaftgap/bellows
that referenced
this pull request
Jun 11, 2026
* Do not allow task cancellation to propagate to ASH * Enter a failed state if we cannot send a frame * Support resolving multiple frames at once (we still limit TX_K=1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of home-assistant/core#119424.
During device joining, zigpy cancels a scheduled initialization task if the device re-joins during initialization (this is pretty common). Unfortunately, this cancellation propagates all the way down to the ASH sending task, causing the TX sequence number to increment without waiting for an acknowledgement. There is currently a firmware bug with EmberZNet and while ASH can support multiple pending frames at a time, in reality the stack crashes if the number is greater than one 😄.
This fix prevents an ASH send from being cancelled by using
asyncio.shield, which schedules it in a task. Incrementing the TX sequence number after a frame has been sent will have similar issues because our last send may not have been ACKed. An alternative to this approach would be to avoid using coroutines entirely for sending and make the ASH protocol implementation rely on event loop callbacks for timeouts.