Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle NAK frames and implement retries #610

Merged
merged 9 commits into from
Feb 5, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Feb 4, 2024

This should significantly increase the reliability of communication and prevent what should have been simple ASH re-sends or timeouts from turning into full reconnects.


This change exists in #606 already, which will be merged in the next release cycle.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1c43536) 99.73% compared to head (eda3f2c) 99.58%.

❗ Current head eda3f2c differs from pull request most recent head 932cc02. Consider uploading reports for the commit 932cc02 to get more accurate results

Files Patch % Lines
bellows/uart.py 77.77% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #610      +/-   ##
==========================================
- Coverage   99.73%   99.58%   -0.16%     
==========================================
  Files          74       74              
  Lines        4987     5014      +27     
==========================================
+ Hits         4974     4993      +19     
- Misses         13       21       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly marked this pull request as ready for review February 5, 2024 16:57
@puddly puddly merged commit 2fe6e86 into zigpy:dev Feb 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants