Implementation for Elf.openFile and Elf.openPath #3163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Sep 3, 2019
| } | ||
|
|
||
| /// Call close when done. | ||
| pub fn openFile(allocator: *mem.Allocator, file: File) !Elf { | ||
| @compileError("TODO implement"); | ||
| var _seekstream = &file.seekableStream().stream; |
There was a problem hiding this comment.
When openFile returns, this becomes a dangling reference.
daurnimator
added
the
standard library
|
Review feedback unaddressed for 2 months. Please feel free to open a new pull request when you are ready for more review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the optional in_file field to the Elf struct for when the struct is the one that opened/owns the file.
Then when calling Elf.close, if in_file is not null, it means the file is ours and we need to close it.
I checked with valgrind, no files left open (except stdin, stdio, stderr obviously).
The only issue I found is that you can't print the Elf struct anymore because of the file, see #2584 .