inline assembly: use types for clobbers #24419
Open
+472
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until now these were stringly typed. it's kinda obvious when you think about it.
andrewrk
added
the
breaking
andrewrk
changed the title
alexrp
reviewed
Jul 12, 2025
| memory: bool, | ||
|
|
||
| cc: bool, | ||
| dirflag: bool, |
There was a problem hiding this comment.
aliasing is fine here. inline assembly might clobber only the dirflag, or it might clobber all the eflags.
There was a problem hiding this comment.
But why are we drawing the line at this flag in particular?
alexrp
reviewed
Jul 12, 2025
| const std = @import("std.zig"); | ||
| const root = @import("root"); | ||
| pub const Clobbers = switch (builtin.cpu.arch) { | ||
| .x86_64 => packed struct { |
There was a problem hiding this comment.
This is missing:
- 16 extra APX registers
- 8 AVX-512 mask registers
- 8 AMX tile registers and 1 config register
- SSP register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now these were stringly typed.
it's kinda obvious when you think about it.
Merge Checklist
std.builtin.Clobbers