Skip to content

std.sort.pdq use correct recursion depth #24403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

std.sort.pdq use correct recursion depth #24403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eb26a0
std.sort.pdq use correct recursion depth
oittaa Jul 11, 2025
1c73b25
Merge branch 'master' into patch-1
oittaa Jul 12, 2025
e855c2d
log2_int doesn't allow zero, return early
oittaa Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/std/sort/pdq.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@ const Hint = enum {
/// which each take 2 `usize` parameters indicating the index of an item.
/// Sorts in ascending order with respect to `lessThan`.
pub fn pdqContext(a: usize, b: usize, context: anytype) void {
if (a == b) return;
// slices of up to this length get sorted using insertion sort.
const max_insertion = 24;
// number of allowed imbalanced partitions before switching to heap sort.
const max_limit = std.math.floorPowerOfTwo(usize, b - a) + 1;
const max_limit = math.log2_int(usize, b - a) + 1;

// set upper bound on stack memory usage.
const Range = struct { a: usize, b: usize, limit: usize };
Expand Down
Loading