Skip to content

test: Enable some working vector tests #24132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Danielkonge
Copy link

As mentioned in #24131, these tests seem to be working fine, so we can enable them again unless I am missing something.

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think you missed one:

andy@bark ~/d/zig (master)> g 20680 test/
test/behavior/vector.zig:        // https://github.com/ziglang/zig/issues/20680
andy@bark ~/d/zig (master)> g 12827 test/
test/behavior/abs.zig:    // https://github.com/ziglang/zig/issues/12827
test/behavior/vector.zig:        // LLVM 15 regression: https://github.com/ziglang/zig/issues/12827

Also don't forget to put "closes #xxxx" in the commit message

@Danielkonge
Copy link
Author

Hmm, CI still gives the error

error: Assertion failed: (llvm::all_of(SrcOps, [&, this](const SrcOp &Op) { return (Op.getLLTTy(*getMRI()).isVector() && Op.getLLTTy(*getMRI()) == SrcOps[0].getLLTTy(*getMRI())); }) && "type mismatch in input list"), function buildInstr, file MachineIRBuilder.cpp, line 1437.

which seems to be the problem in #20680, but I cannot reproduce it locally. (Even with the -ODebug flag.)

I will try to see if I can just get the fix to #12827 through CI, and then I will update the PR. Otherwise I will close it for now (and try to figure out why everything works on my M1 mac locally).

@andrewrk
Copy link
Member

andrewrk commented Jun 9, 2025

which seems to be the problem in #20680, but I cannot reproduce it locally. (Even with the -ODebug flag.)

Likely you are using LLVM without assertions enabled.

@Danielkonge
Copy link
Author

I updated the PR with a commit message saying it closes #12827. Since my previous run got through CI on x86 macOS, I hope it is true that #12827 is fixed at least. (Also that test didn't seem to be an LLVM assertion failure if I read the error correctly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants