std.Build.Step.Compile: fix race condition in args file creation

[ianprime0509]

Fixes #23993

Previously, if multiple build processes tried to create the same args file, there was a race condition with the use of the non-atomic writeFile function which could cause a spawned compiler to read an empty or incomplete args file. This commit avoids the race condition by first writing to a temporary file with a random path and renaming it to the desired path.

---

This follows the same strategy as the package fetching code, including the convention of tmp/<random u64 hex> as the temporary file name.

I tested this with the original reproducer from the linked issue, and I'm no longer seeing any errors with this change applied. I also tested it with the .zig-cache directory deleted, to make sure it works properly on the first run, before the args file is created.

[ianprime0509]

It's worth noting that the package fetching code also handles error.AccessDenied:

zig/src/Package/Fetch.zig

Line 1446 in ef35c3d

error.PathAlreadyExists, error.AccessDenied => {

However, based on the documentation for RenameError, it looks like that case is only relevant for directories, not files as in this case:

zig/lib/std/posix.zig

Lines 2595 to 2597 in ef35c3d

	/// On Windows, this error may be returned instead of PathAlreadyExists when
	/// renaming a directory over an existing directory.
	AccessDenied,

so this code doesn't handle it.