-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
replace @Type with individual type-creating builtins #23733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
687062e
to
c7bb559
Compare
Although it was not listed in the issue, would it be reasonable to add |
Seems like a good change. I like it. Though, is it necessary to remove |
|
Oh, yeah. That makes sense. Thanks. Then, I don't see why this change can't be accepted. Seems pretty useful and straightforward. |
Does Each of the fields of those are of different types thus It's not possible to pass the wrong type for any of those and if the |
Someone asked me about the status of this PR, so just commenting to say that I'm aware of it, and appreciate the effort that went into it -- I'd definitely like to avoid letting this work rot. I'll hopefully get to it soon, but we have some huge changes currently in the pipeline, so the team's all a little busy right now, and it's not a great time to merge big breaking PRs. I'm hoping I'll be able to have a look at this once the reader/writer changes, and codegen pipeline changes, are all in, and everything's settling down a little. No need to worry about rebasing or anything, I will probably be happy to resolve conflicts when I get around to reviewing this. One note: I am firmly of the opinion that there should be an By the way, @alichraghi: were the usages of |
Yeah i figured that this is gonna take long and im fine with handling conflicts myself. was mostly waiting for writergate branch to be merged.
They are updated by hand but it wasn't painful because most new builtins accept the same |
3d17739
to
9a324c7
Compare
Closes #10710
I updated
zig1.wasm
in first commit to ensure the CI is passing. once ready, one of the core team members can handle updating it.I also didn't add
@Array
because as @Hejsil pointed out, it can be implemented in a single line of user-land code.Same goes for
@Float
.std.meta.Float()
is no longer a wrapper of@Type
.