std.Progress: fix many bugs #23725
Open
std.Progress: fix many bugs #23725
+89
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention: achan1989's repro is indeed able to consistently trigger the crash for me on master, and does not on this branch. I also don't see any garbled output or other issues. |
|
TSan also much prefers this to master; with a slightly modified version of achan1989's repro, I get a lot of TSan warnings followed by an assertion failure on master, whereas on this branch it just runs indefinitely without a problem. |
NicoElbers
reviewed
Apr 29, 2025
There were several bugs with the synchronization here; most notably an ABA problem which was causing ziglang#21663. I fixed that and some other issues, and took the opportunity to get rid of the `.seq_cst` orderings from this file. I'm at least relatively sure my new orderings are correct. Co-authored-by: achan1989 <[email protected]> Resolves: ziglang#21663
|
This is much easier to read and understand now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several bugs with the synchronization here; most notably an ABA problem which was causing #21663. I fixed that and some other issues, and took the opportunity to get rid of the
.seq_cstorderings from this file. I'm at least relatively sure my new orderings are correct.Thanks to @achan1989 for noticing the ABA problem here and putting up an initial fix. This PR supersedes #23662, but I've marked you as a co-author here!
Resolves: #21663