Skip to content

Conversation

@elerch
Copy link
Contributor

@elerch elerch commented Apr 20, 2025

This addresses #23610 and very possibly #23453. The diff is semanticly equivalent to this diff, just cleaned up to remove the block that became unnecessary. All behavior tests pass.

diff --git i/src/main.zig w/src/main.zig
index 107599384..50363c68d 100644
--- i/src/main.zig
+++ w/src/main.zig
@@ -3040,7 +3040,6 @@ fn buildOutputType(
                 .builtin_mod = main_mod.getBuiltinDependency(),
                 .builtin_modules = null, // `builtin_mod` is specified
             });
-            test_mod.deps = try main_mod.deps.clone(arena);
             break :test_mod test_mod;
         } else try Package.Module.create(arena, .{
             .global_cache_directory = global_cache_directory,
@@ -3060,6 +3059,7 @@ fn buildOutputType(
             .builtin_modules = null, // `builtin_mod` is specified
         });

+        test_mod.deps = try main_mod.deps.clone(arena);
         break :root_mod test_mod;
     } else main_mod;

@alexrp alexrp requested a review from mlugg April 20, 2025 22:44
@alexrp
Copy link
Member

alexrp commented May 2, 2025

Needs a rebase to resolve conflicts.

@elerch elerch force-pushed the release-mode-test branch from aa53fe7 to 910271e Compare May 5, 2025 23:46
@elerch
Copy link
Contributor Author

elerch commented May 5, 2025

rebased onto a14352b

@mlugg
Copy link
Member

mlugg commented Jul 30, 2025

I think this may already be fixed on master thanks to #23836. Will test shortly.

@mlugg
Copy link
Member

mlugg commented Jul 30, 2025

Confirmed already fixed. Thank you though!

@mlugg mlugg closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants