std.crypto: add pem.zig #23399
std.crypto: add pem.zig #23399
Conversation
lib/std/crypto/pem.zig
Outdated
|
|
||
| const Self = @This(); | ||
|
|
||
| /// init |
There was a problem hiding this comment.
Please avoid writing redundant comments.
lib/std/crypto/pem.zig
Outdated
| fn isSpace(r: u8) bool { | ||
| return switch(r) { | ||
| '\t', '\n', '\r', ' ', 0x85, 0xA0 => true, | ||
| else => false, | ||
| }; | ||
| } | ||
|
|
||
| fn trimSpace(s: []const u8) []const u8 { | ||
| var start: usize = 0; | ||
| while (start < s.len) : (start += 1) { | ||
| if (!isSpace(s[start])) { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| var stop = s.len - 1; | ||
| while (stop > start) : (stop -= 1) { | ||
| if (!isSpace(s[stop])) { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (start == stop) { | ||
| return ""; | ||
| } | ||
|
|
||
| return s[start..(stop+1)]; | ||
| } |
There was a problem hiding this comment.
These functions already exist in std.ascii and std.mem
lib/std/crypto/pem.zig
Outdated
| fn contains(data: []const u8, sep: []const u8) bool { | ||
| const i = mem.indexOf(u8, data, sep); | ||
| if (i != null) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Why not directly use mem.indexOf?
lib/std/crypto/pem.zig
Outdated
| } | ||
|
|
||
| fn hasSuffix(rest: []const u8, needle: []const u8) bool { | ||
| return rest.len > needle.len and mem.eql(u8, rest[rest.len-needle.len..], needle); | ||
| } | ||
|
|
There was a problem hiding this comment.
mem.startsWith/mem.endsWith
lib/std/crypto/pem.zig
Outdated
| @@ -0,0 +1,540 @@ | |||
| const std = @import("std"); | |||
There was a problem hiding this comment.
The whole implementation is inefficient.
e.g. There are multiple allocations that could be combined into one.
There was a problem hiding this comment.
@alichraghi How do change it? I think what it is right.
lib/std/crypto/pem.zig
Outdated
|
|
||
| const pem_line_length = 64; | ||
|
|
||
| fn writeHeader(writer: anytype, k: []const u8, v: []const u8) !void { |
There was a problem hiding this comment.
You'd want to rename this to fn appendHeader(list: *std.ArrayList(u8), ...) because a writer (at least as a convention) doesn't have a appendSlice method
lib/std/crypto/pem.zig
Outdated
| "ILwpnZ1izL4MlI9eCSHhVQBHEp2uQdXJB+d5Byg=\n" ++ | ||
| "-----END CERTIFICATE-----\n"; | ||
|
|
||
| const alloc = std.heap.page_allocator; |
There was a problem hiding this comment.
Use std.testing.allocator instead
| const buffer = try allocator.alloc(u8, bytes_len); | ||
|
|
||
| const banse64_encoded = base64.standard.Encoder.encode(buffer, b.bytes); | ||
|
|
There was a problem hiding this comment.
Encoding/decoding should really be done in constant time.
We currently don't have hex/base64 codecs suitable for secrets, but that should probably be the first thing to add before adding PEM encoding.
https://github.com/jedisct1/libsodium/blob/master/src/libsodium/sodium/codecs.c can easily be ported to Zig.
There was a problem hiding this comment.
The pem.zig use the std.base64.
There was a problem hiding this comment.
Just noting that #23420 has been merged in case you want to rebase and make use of it.
No description provided.